Updated tests for examples (f31c36f2) · Commits · Isfand Yar Khan / request-promise

package.json

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -39,6 +39,7 @@
	"chai": "2.2.x",		"chai": "2.2.x",
	"chai-as-promised": "4.3.x",		"chai-as-promised": "4.3.x",
	"chalk": "^1.1.1",		"chalk": "^1.1.1",
			"cheerio": "^0.19.0",
	"continuation-local-storage": "^3.1.4",		"continuation-local-storage": "^3.1.4",
	"event-stream": "3.3.x",		"event-stream": "3.3.x",
	"gulp": "3.8.x",		"gulp": "3.8.x",

test/spec/request-test.js

+111 −25

Original line number	Original line	Diff line number	Diff line
	@@ -20,12 +20,15 @@ describe('Request-Promise', function () {
	server = http.createServer(function (request, response) {		server = http.createServer(function (request, response) {
	(bodyParser.json())(request, response, function () {		(bodyParser.json())(request, response, function () {
	var path = url.parse(request.url).pathname;		var path = url.parse(request.url).pathname;
	var status = parseInt(path.split('/')[1]);		var status = parseInt(path.split('?')[0].split('/')[1]);
	if(isNaN(status)) { status = 555; }		if(isNaN(status)) { status = 555; }
	if (status === 302) {		if (status === 302) {
	response.writeHead(status, { location: '/200' });		response.writeHead(status, { location: '/200' });
	lastResponseBody = '';		lastResponseBody = '';
	response.end();		response.end();
			} else if (status === 222) {
			response.writeHead(status, { 'Content-Type': 'text/html' });
			response.end('<html><head></head><body></body></html>');
	} else {		} else {
	response.writeHead(status, { 'Content-Type': 'text/plain' });		response.writeHead(status, { 'Content-Type': 'text/plain' });
	var body = (request.method === 'POST' && JSON.stringify(request.body) !== '{}' ? ' - ' + JSON.stringify(request.body) : '');		var body = (request.method === 'POST' && JSON.stringify(request.body) !== '{}' ? ' - ' + JSON.stringify(request.body) : '');
	@@ -1061,76 +1064,159 @@ describe('Request-Promise', function () {

	describe('should run the examples', function () {		describe('should run the examples', function () {

	it('in the README', function () {		it('in the Cheat Sheet section of the README', function () {

	this.timeout(10000);		this.timeout(10000);

	var options;

	return Bluebird.resolve()		return Bluebird.resolve()
	.then(function () {		.then(function () {

	return rp('http://www.google.com')		return rp('http://localhost:4000/222')
	.then(function (body) {		.then(function (htmlString) {
	expect(body).to.contain('</html>');		// Process html...
			expect(htmlString).to.contain('</html>');
	})		})
	.catch(function (err) {		.catch(function (err) {
			// Crawling failed...
	throw err;		throw err;
	});		});

	// --> 'GET's and displays google.com		})
			.then(function () {

			var cheerio = require('cheerio'); // Basically jQuery for node.js

			var options = {
			uri: 'http://localhost:4000/222',
			transform: function (body) {
			return cheerio.load(body);
			}
			};

			return rp(options)
			.then(function ($) {
			// Process html like you would with jQuery...
			expect($('html').length).to.eql(1);
			})
			.catch(function (err) {
			// Crawling failed or Cheerio choked...
			throw err;
			});

	})		})
	.then(function () {		.then(function () {

	options = {		// ### GET something from a JSON REST API

			var options = {
	uri: 'http://localhost:4000/200',		uri: 'http://localhost:4000/200',
	method : 'POST',		qs: {
	json: true,		access_token: 'xxxxx xxxxx' // -> uri + '?access_token=xxxxx%20xxxxx'
	body: { some: 'payload' }		},
			headers: {
			'User-Agent': 'Request-Promise'
			},
			json: true // Automatically parses the JSON string in the response
	};		};

	return rp(options)		return rp(options)
	.then(function (body) {		.then(function (repos) {
	expect(body).to.eql('POST /200 - {"some":"payload"}');		console.log('User has %d repos', repos.length);
	})		})
	.catch(function (err) {		.catch(function (err) {
			// API call failed...
	throw err;		throw err;
	});		});

	// --> Displays response from server after post

	})		})
	.then(function () {		.then(function () {

	options.transform = function (data) { return data.length; };		// ### POST data to a JSON REST API

			var options = {
			method: 'POST',
			uri: 'http://localhost:4000/200',
			body: {
			some: 'payload'
			},
			json: true // Automatically stringifies the body to JSON
			};

	return rp(options)		return rp(options)
	.then(function (body) {		.then(function (parsedBody) {
	expect(body).to.eql('POST /200 - {"some":"payload"}'.length);		// POST succeeded...
			expect(parsedBody).to.eql('POST /200 - {"some":"payload"}');
	})		})
	.catch(function (err) {		.catch(function (err) {
			// POST failed...
	throw err;		throw err;
	});		});

	// transform is called just before promise is fulfilled		})
	// --> Displays length of response from server after post		.then(function () {

			// ### POST like HTML forms do

			var options = {
			method: 'POST',
			uri: 'http://localhost:4000/200',
			form: {
			some: 'payload' // Will be urlencoded
			},
			headers: {
			/* 'content-type': 'application/x-www-form-urlencoded' */ // Set automatically
			}
			};

			return rp(options)
			.then(function (parsedBody) {
			// POST succeeded...
			})
			.catch(function (err) {
			// POST failed...
			throw err;
			});

	})		})
	.then(function () {		.then(function () {

	// Get full response after DELETE		// ### Get the full response instead of just the body
	options = {
			var options = {
	method: 'DELETE',		method: 'DELETE',
	uri: 'http://localhost:4000/200',		uri: 'http://localhost:4000/200',
	resolveWithFullResponse: true		resolveWithFullResponse: true // <--- <--- <--- <---
	};		};

	return rp(options)		return rp(options)
	.then(function (response) {		.then(function (response) {
			console.log("DELETE succeeded with status %d", response.statusCode);
	expect(response.statusCode).to.eql(200);		expect(response.statusCode).to.eql(200);
	})		})
	.catch(function (err) {		.catch(function (err) {
			// Delete failed...
			throw err;
			});

			})
			.then(function () {

			// ### Get a rejection only if the request failed for technical reasons

			var options = {
			uri: 'http://localhost:4000/404',
			simple: false, // <--- <--- <--- <---
			resolveWithFullResponse: true
			};

			return rp(options)
			.then(function (response) {
			// Request succeeded but might as well be a 404
			// Usually combined with resolveWithFullResponse = true to check response.statusCode
			expect(response.statusCode).to.eql(404);
			})
			.catch(function (err) {
			// Request failed due to technical reasons...
	throw err;		throw err;
	});		});