Optimized transform call (3ee88b7d) · Commits · Isfand Yar Khan / request-promise

lib/rp.js

+5 −3

Original line number	Diff line number	Diff line
		@@ -31,9 +31,11 @@ function ownCallback(err, httpResponse, body) {
		});
		} else {
		if (_.isFunction(self._rp_options.transform)) {
		self._rp_resolve(new Bluebird(function (resolve) {
		resolve(self._rp_options.transform(body, httpResponse));
		}));
		try {
		self._rp_resolve(self._rp_options.transform(body, httpResponse));
		} catch (e) {
		self._rp_reject(e);
		}
		} else if (self._rp_options.resolveWithFullResponse) {
		self._rp_resolve(httpResponse);
		} else {

+17 −0

Original line number	Diff line number	Diff line
		@@ -289,6 +289,23 @@ describe('Request-Promise', function () {

		});

		it('that returns a rejected promise', function () {

		var options = {
		url: 'http://localhost:4000/200',
		transform: function (body) {
		return new Bluebird(function (resolve, reject) {
		setTimeout(function () {
		reject(new Error('Transform rejected!'));
		});
		});
		}
		};

		return expect(rp(options)).to.be.rejected;

		});

		it('that throws an exception', function () {

		var options = {